Hi,

2012-03-08 7:41 AM, Arun Sharma wrote:
This patch series refactors existing code a bit and adds sort by
inclusive time (time spent in the function + callees).

Sample command lines:

# perf record -ag -- sleep 1
# perf report -g graph,0.5,callee -n -s inclusive

Known bugs:

total_period computation is broken for order=callee


I'd like to add two more :).

* If perf record misses callchain info, perf report will get stuck.
* If it's used with "symbol" sort order, it'll get stuck too.


BTW, I don't like the name 'inclusive' as a sort key. If it cares about time, IMHO, the name should contain 'time' - something like 'itime' or 'inctime'?

Furthermore, I don't think it is a sort key. As it doesn't sort anything, and only affects the way calculating symbol's period value, wouldn't it be better making it a separate switch rather than a sort key? Plus, checking whether it has callchain data and symbol sort key might be added also.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-perf-users" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to