Re: Help RAID5 reshape Oops / backup-file

[Nagilum]

----- Message from [EMAIL PROTECTED] ---------
    Date: Fri, 12 Oct 2007 09:51:08 +1000
    From: Neil Brown <[EMAIL PROTECTED]>
Reply-To: Neil Brown <[EMAIL PROTECTED]>
 Subject: Re: Help RAID5 reshape Oops / backup-file
      To: Nagilum <[EMAIL PROTECTED]>
      Cc: linux-raid@vger.kernel.org

On Thursday October 11, [EMAIL PROTECTED] wrote:

Ok, after looking in "Grow.c" I can see that the backup file is
removed once the critial section has passed:

                if (backup_file)
                        unlink(backup_file);

                printf(Name ": ... critical section passed.\n");

Since I had passed that point I'll try to find out where
Grow_restart() stumbles. By looking at it I'm not even sure it's able
to "resume" and not just restart. :-/

It isn't a problem that you didn't specify a backup-file.
If you don't, mdadm uses some spare space on one of the new drives.
After the critical section has passed, the backup file isn't needed
any longer.
The problem is that mdadm still wants to find and recover from it.

I throughly tested mdadm restarting from a crash during the critical
section, but it looks like I didn't properly test restarting from a
later crash.

I think if you just change the 'return 1' at the end of Grow_restart
to 'return 0' it should work for you.

I'll try to get this fixed properly (and tested) and release a 2.6.4.

NeilBrown

----- End message from [EMAIL PROTECTED] -----

Thanks, I changed Grow_restart as suggested, now I get:
nas:~/mdadm-2.6.3# ./mdadm -A /dev/md0 /dev/sd[a-e]


nas:~/mdadm-2.6.3# cat /proc/mdstat
Personalities : [raid6] [raid5] [raid4]
md0 : inactive sda[0] sde[6] sdd[5] sdc[2] sdb[1]
      2441543360 blocks

unused devices: <none>

which is similar to what the old mdadm is telling me.
I'll try to find out where it gets the idea these are spares..

If there is anything I can do to help with v2.6.4 let me know!
Thanks,
Alex.

========================================================================
#    _  __          _ __     http://www.nagilum.org/ \n icq://69646724 #
#   / |/ /__ ____ _(_) /_ ____ _  [EMAIL PROTECTED] \n +491776461165 #
#  /    / _ `/ _ `/ / / // /  ' \  Amiga (68k/PPC): AOS/NetBSD/Linux   #
# /_/|_/\_,_/\_, /_/_/\_,_/_/_/_/   Mac (PPC): MacOS-X / NetBSD /Linux #
#           /___/     x86: FreeBSD/Linux/Solaris/Win2k  ARM9: EPOC EV6 #
========================================================================


----------------------------------------------------------------
cakebox.homeunix.net - all the machine one needs..

mdadm: /dev/md0 assembled from 3 drives and 2 spares - not enough to start the array. Would it be a good idea to update to vanilla 2.6.23 instead of running Debian Etch's 2.6.18-5?

pgpdgRJbJZVe9.pgp
Description: PGP Digital Signature