On Mon, 2011-10-24 at 18:45 +0200, Bart Van Assche wrote: > On Mon, Oct 24, 2011 at 7:57 AM, Nicholas A. Bellinger > <n...@linux-iscsi.org> wrote: > > This v2 patch adds the kernel module ib_srpt SCSI RDMA Protocol (SRP) target > > implementation conforming to the SRP r16a specification for the mainline > > drivers/target infrastructure. > > > > This driver was originally developed by Vu Pham and has been optimized by > > Bart Van Assche and merged into upstream LIO based on his srpt-lio-4.1 > > branch. > > This patch is made against the current pending target-core changes for > > v3.2-rc1, the full tree is available here: > > Maybe you remember that the reason why I developed this patch was to > be able to run performance measurements ? The following changes are > necessary to convert this patch into a robust kernel driver: > - Handle the case where the last WQE event arrives before the > corresponding queue pair is reset (r3870 in the SCST SVN repo). > - Handle IB completion timeouts. Although the InfiniBand Architecture > Manual specifies that a HCA must generate an error completion for each > pending work item when a queue pair reset is issued, an important > class of HCAs doesn't do this (that includes the HCA in your test > setup). In the SCST version of this driver such timeouts are handled > by the function srpt_pending_cmd_timeout(). > > Both issues mentioned above can lead to sessions not being cleaned up > properly and hence all future logins from the initiator associated > with that session to be blocked. >
It would have been nice if you bothered to mention these in any of the pre merge window reviews, but given your delay responsed on these items they will have to be something we'll fix post merge. Thanks, --nab -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
