From: Hariprasad Shenai <haripra...@chelsio.com> Date: Tue, 4 Nov 2014 08:20:54 +0530
> It's not really the "hardware" which generates these hardware constant > symbolic > macros/register defines of course, it's scripts developed by the hardware > team. > Various patches have ended up changing the style of the symbolic > macros/register > defines and some of them used the macros/register defines that matches the > output of the script from the hardware team. We've told you that we don't care what format your internal whatever uses for these macros. We have standards, tastes, and desires and reasons for naming macros in a certain way in upstream kernel code. I consider it flat out unacceptable to use macros with one letter prefixes like "S_". You simply should not do this. Why? Because you are polluting the global name space, that's why. You should only define macros with very-likely-to-be-unique prefixes otherwise you and some arch/* header file are going to define the same thing. This is not just theory, it has happened in the past. I'm not applying this series, fixup your macros properly. And to repeat, complaints about how your internal tools generate things will fall on deaf ears. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
