On Wed, Dec 09, 2015 at 10:42:35AM -0800, Christoph Hellwig wrote: > On Tue, Dec 08, 2015 at 07:52:03PM -0500, ira.weiny wrote: > > Searching patchworks... > > > > I'm a bit worried about the size of the patch and I would like to see it > > split > > up for review. But I agree Christophs method is better long term. > > I'd be happy to split it up if I could see a way to split it. So if > anyone has an idea you're welcome!
Well this is a ~3300 line patch which is pretty hard to review in total. > > > Christoph do you have this on github somewhere? Perhaps it is split but I'm > > not finding in on patchworks? > > No need for github, we have much better (and older) git hosting sites :) > > http://git.infradead.org/users/hch/rdma.git/shortlog/refs/heads/ib_device_attr Another nice side effect of this patch is to get rid of all the struct ib_device_attr allocations which are littered all over the ULPs. For the core, srp, ipoib, qib, hfi1 bits. Generally the rest looks fine I just did not have time to really go through it line by line. Reviewed-by: Ira Weiny <ira.we...@intel.com> Doug this is going to conflict with the rdmavt work. So if you take this could you respond on the list. Thanks, Ira -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
