Hello Kieran, Thank you so much for the background!
I think we are going to live without colour keying for now, I'll let you know if we decide to pick this up, so that we don't step on each other's toes. Thanks! Fab > From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > Sent: 12 April 2019 13:28 > Subject: Re: Color Keying > > Hello Again, > > It looks like someone else has also tried to rejuvenate the DRM generic > colorkey support from Laurent at: > > https://lore.kernel.org/linux-renesas-soc/20180807172202.1961-2-dig...@gmail.com/ > > So that may or may not conflict. But it suggests that if you can get > Laurent's old patches working then it will help your use case - but > probably needs more considerable work before we can integrate into mainline. > > -- > Kieran > > > > On 12/04/2019 13:23, Kieran Bingham wrote: > > Hi Fabrizio, > > > > On 12/04/2019 11:12, Fabrizio Castro wrote: > >> Hello Laurent, > >> > >> has colour keying ever been tested on R-Car Gen3? > >> I am working on HDMI support for the RZ/G2E, and I wanted to test > >> "colorkey", but it > >> looks like that once you have RCAR_DU_FEATURE_VSP1_SOURCE defined within > >> the > >> features member of the SoC specific rcar_du_device_info struct, > >> rcar_du_modeset_init > >> won't call rcar_du_planes_init. > >> > >> Is my understanding correct? > >> Is this behaviour desired? > >> Is there anything I can do to quickly test it on my RZ/G2E? > > > > It looks like this has been attempted a couple of times but might not > > yet be completed. Perhaps you have the required necessity to refresh the > > patches? If not, let us know and we'll see what we can with our next > > batch of tasks. > > > > At [0] I see that there was a pull request to incorporate Gen3 color > > keying support into the renesas drivers, but it was removed some time > > after due to conflicts [1]. > > > > [0] https://lore.kernel.org/linux-renesas-soc/5151514.osXWQNHT4Q@avalon/ > > [1] > > https://lore.kernel.org/linux-renesas-soc/camuhmdu7fjz43+mtgwqfzx6fx6zyafyw+sy-uopz5gx2hdo...@mail.gmail.com/ > > > > You could try fetching the commits from > > git://linuxtv.org/pinchartl/media.git > > tags/drm-next-colorkey-v1-20171215 > > > > And try to cherry-pick them to mainline to see if that brings the > > functionality you require. > > > > > > A patch was provided for kms-tests at [2] which might help you validate > > the patches. > > > > [2] > > https://lore.kernel.org/linux-renesas-soc/20171215134848.19680-1-laurent.pinch...@ideasonboard.com/ > > > > > > If you successfully rebase and test the patches, please consider > > reposting them from the new base to rejuvenate the effort to get them > > integrated. > > > > If you have any difficulties please let us know, but I'm afraid I'm on > > holiday next week so there is not much I can do until after I return. > > > > -- > > Regards > > > > Kieran > > > > > > > >> Thanks, > >> Fab > >> > >> > >> > >> > >
