On 04/17/2019 09:21 AM, masonccy...@mxic.com.tw wrote: >> >> Re: [PATCH v10 1/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD >> controller driver >> >> >> >> The patch name is somewhat misleading -- there's no "MFD controller". >> > >> > Can't get your point ? >> > >> > RPC-IF support SPI and HF, it's a MFD controller and >> > that's why I patch it to MFD as Marek's comments. >> >> I'd like the "controller" word dropped, as MFD stands for multi- >> function device >> anyway. "Controller" seems to be superfluous here... > > okay, will rename to: > > [PATCH v11 1/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD driver
Thanx! >> >> On 04/15/2019 10:37 AM, Mason Yang wrote: >> >> >> >> > Add a driver for Renesas R-Car Gen3 RPC-IF MFD controller. >> >> > >> >> > Signed-off-by: Mason Yang <masonccy...@mxic.com.tw> >> >> [...] >> >> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig >> >> > index 26ad646..7914349 100644 >> >> > --- a/drivers/mfd/Kconfig >> >> > +++ b/drivers/mfd/Kconfig >> >> > @@ -978,6 +978,15 @@ config MFD_RDC321X >> >> > southbridge which provides access to GPIOs and Watchdog using the >> >> > southbridge PCI device configuration space. >> >> > >> >> > +config MFD_RENESAS_RPC >> >> > + tristate "Renesas R-Car Gen3 RPC-IF MFD driver" >> >> > + select MFD_CORE >> >> > + depends on ARCH_RENESAS >> >> > + help >> >> > + This supports for Renesas R-Car Gen3 RPC-IF multifunction device >> >> >> >> "For" node needed here. >> > >> > ? >> >> Sorry, that was a typo: s/node/not/. > > Oops, still don't know what do you mean to ? > > Will change to: > help > This supports for Renesas R-Car Gen3 RPC-IF multifunction device > which provides either SPI host or HyperFlash. > You have to select individual components under the corresponding > menu. > > is it ok ? Should be "This supports Renesas..." [...] MBR, Sergei
