On Tue, Mar 29, 2005 at 08:49:33AM -0800, Mark Haverkamp wrote: > I ran sparse on the driver and without the -Wbitwise, it only has 7 > warnings such as: > > CHECK drivers/scsi/aacraid/linit.c > drivers/scsi/aacraid/linit.c:218:12: warning: symbol 'aac_info' was not > declared. Should it be static? > > With -Wbitwise there are about 200 warnings of this sort: > drivers/scsi/aacraid/aachba.c:180:18: warning: incorrect type in assignment > (different base types) > drivers/scsi/aacraid/aachba.c:180:18: expected unsigned int [unsigned] > [usertype] command > drivers/scsi/aacraid/aachba.c:180:18: got restricted unsigned int > [usertype] [force] <noident> > > What is your preference, I could clean up the existing patch and re- > submit and then address the sparse warnings with a follow-up patch. Or > try to fix everything in one patch.
I think we can postpone the sparse fixes to a followon patch. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
