Acked-by: James Smart <james.sm...@emulex.com>

Thanks

-- james  s




On 9/5/2012 2:49 AM, Wei Yongjun wrote:
From: Wei Yongjun <yongjun_...@trendmicro.com.cn>

Using list_move_tail() instead of list_del() + list_add_tail().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_...@trendmicro.com.cn>
---
  drivers/scsi/lpfc/lpfc_sli.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 9cbd20b..0ada66b 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -15833,8 +15833,7 @@ lpfc_cleanup_pending_mbox(struct lpfc_vport *vport)
                        (mb->u.mb.mbxCommand != MBX_REG_VPI))
                        continue;
- list_del(&mb->list);
-               list_add_tail(&mb->list, &mbox_cmd_list);
+               list_move_tail(&mb->list, &mbox_cmd_list);
        }
        /* Clean up active mailbox command with the vport */
        mb = phba->sli.mbox_active;




--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to