On 04/15/2013 03:45 PM, James Bottomley wrote: > On Mon, 2013-04-15 at 13:39 -0500, wenxi...@linux.vnet.ibm.com wrote: >> In scsi_send_eh_cmnd(), this fix will check the return code of queuecomamnd >> when sending commands and retry for a bit if the driver returns a >> busy response. > > This is already handled by the timeout, I think. If a driver > continuously returns MLQUEUE BUSY, then we'll fail the request after the > timeout on the command expires.
If we get a timeout in scsi_send_eh_cmnd we call scsi_abort_eh_cmnd. If the abort works, we return FAILED out of scsi_send_eh_cmnd, which results in no retry being performed, since scsi_eh_tur only retries once and only if NEEDS_RETRY is returned. Or am I missing something? Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
