On Wed, 2017-01-11 at 12:02 -0600, Bryant G. Ly wrote: > Current code incorrectly calculates the max transfer length, since > it is assuming a 4k page table, but ppc64 all run on 64k page tables. > > Cc: sta...@vger.kernel.org > Reported-by: Steven Royer <sero...@linux.vnet.ibm.com> > Tested-by: Steven Royer <sero...@linux.vnet.ibm.com> > Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> > --- > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > index 8fb5c54..792a8bd 100644 > --- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > +++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > @@ -1443,7 +1443,7 @@ static long ibmvscsis_adapter_info(struct scsi_info > *vscsi, > info->mad_version = cpu_to_be32(MAD_VERSION_1); > info->os_type = cpu_to_be32(LINUX); > memset(&info->port_max_txu[0], 0, sizeof(info->port_max_txu)); > - info->port_max_txu[0] = cpu_to_be32(128 * PAGE_SIZE); > + info->port_max_txu[0] = cpu_to_be32(16 * PAGE_SIZE); > > dma_wmb(); > rc = h_copy_rdma(sizeof(*info), vscsi->dds.window[LOCAL].liobn,
Hello Bryant, The old limit was intended to be 128 * 4 KB = 512 KB. The new limit is 16 * 64 KB = 1024 KB. Is that intended? Do I understand correctly that the max_txu value is independent of the page size? If so, have you considered to introduce a #define for the max_mtu value that specifies max_mtu as a number instead of as a multiple of the page size? At least in the SLES 10 SP3 ibmvscsis.c code max_mtu was not defined as a multiple of the page size. Thanks, Bart.-- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
