> -----Original Message----- > From: Bart Van Assche [mailto:bart.vanass...@sandisk.com] > Sent: Tuesday, April 25, 2017 3:13 PM > To: h...@infradead.org; Viswas G <viswa...@microsemi.com>; Gerry > Morong <gerry.mor...@microsemi.com>; Mahesh Rajashekhara > <mahesh.rajashekh...@microsemi.com>; posw...@suse.com; Scott > Benesh <scott.ben...@microsemi.com>; Don Brace > <don.br...@microsemi.com>; Bader Ali - Saleh > <bader.alisa...@microsemi.com>; Kevin Barnett > <kevin.barn...@microsemi.com>; joseph.szczy...@hpe.com; Scott Teel > <scott.t...@microsemi.com>; j...@linux.vnet.ibm.com; Justin Lindley > <justin.lind...@microsemi.com>; John Hall <john.h...@microsemi.com> > Cc: linux-scsi@vger.kernel.org > Subject: Re: [PATCH 20/37] smartpqi: add ptraid support > > EXTERNAL EMAIL > > > On Tue, 2017-04-25 at 14:47 -0500, Don Brace wrote: > > +static inline bool pqi_is_external_raid_device(struct pqi_scsi_dev > *device) > > +{ > > + return device->is_external_raid_device; > > +} > > The name of this function is almost as long as its implementation. Please drop > this function definition and inline the function into its callers. > > Thanks, > > Bart. Done
Thanks, Don Brace ESC - Smart Storage Microsemi Corporation
