From: Quinn Tran <quinn.t...@cavium.com>

When driver is unloaded, all sessions are torn down, all
commmands are flushed, chip is reset to ensure there is
no knowledge of target mode in ISP. The irq_cmd_count field
was used to make sure all commands are processed on top of that.
The irq_cmd_count is now redundant and not needed.

Signed-off-by: Quinn Tran <quinn.t...@cavium.com>
Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com>
---
 drivers/scsi/qla2xxx/qla_target.c | 9 +--------
 drivers/scsi/qla2xxx/qla_target.h | 1 -
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_target.c 
b/drivers/scsi/qla2xxx/qla_target.c
index 5a8ed73e6ef2..95aad9c329d7 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -5326,8 +5326,6 @@ static void qlt_response_pkt(struct scsi_qla_host *vha, 
response_t *pkt)
         * Otherwise, some commands can stuck.
         */
 
-       tgt->irq_cmd_count++;
-
        switch (pkt->entry_type) {
        case CTIO_CRC2:
        case CTIO_TYPE7:
@@ -5353,10 +5351,8 @@ static void qlt_response_pkt(struct scsi_qla_host *vha, 
response_t *pkt)
                }
 
                rc = qlt_chk_qfull_thresh_hold(vha, atio, true);
-               if (rc != 0) {
-                       tgt->irq_cmd_count--;
+               if (rc != 0)
                        return;
-               }
 
                rc = qlt_handle_cmd_for_atio(vha, atio);
                if (unlikely(rc != 0)) {
@@ -5488,7 +5484,6 @@ static void qlt_response_pkt(struct scsi_qla_host *vha, 
response_t *pkt)
                break;
        }
 
-       tgt->irq_cmd_count--;
 }
 
 /*
@@ -5518,7 +5513,6 @@ void qlt_async_event(uint16_t code, struct scsi_qla_host 
*vha,
         * Otherwise, some commands can stuck.
         */
 
-       tgt->irq_cmd_count++;
 
        switch (code) {
        case MBA_RESET:                 /* Reset */
@@ -5606,7 +5600,6 @@ void qlt_async_event(uint16_t code, struct scsi_qla_host 
*vha,
                break;
        }
 
-       tgt->irq_cmd_count--;
 }
 
 static fc_port_t *qlt_get_port_database(struct scsi_qla_host *vha,
diff --git a/drivers/scsi/qla2xxx/qla_target.h 
b/drivers/scsi/qla2xxx/qla_target.h
index de6b8c3a863e..6ce720f9f890 100644
--- a/drivers/scsi/qla2xxx/qla_target.h
+++ b/drivers/scsi/qla2xxx/qla_target.h
@@ -790,7 +790,6 @@ struct qla_tgt {
         * because req_pkt() can drop/reaquire HW lock inside. Protected by
         * HW lock.
         */
-       int irq_cmd_count;
        int atio_irq_cmd_count;
 
        int datasegs_per_cmd, datasegs_per_cont, sg_tablesize;
-- 
2.12.0

Reply via email to