If every_nth > 0, the injection flags must be reset for commands
that aren't supposed to fail (i.e. that aren't "nth"). Otherwise,
commands will continue to fail, like in the every_nth < 0 case.

Signed-off-by: Martin Wilck <mwi...@suse.com>
---
 drivers/scsi/scsi_debug.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index 86c48797381e..820b98853e69 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -3988,8 +3988,13 @@ static void clear_queue_stats(void)
 static void setup_inject(struct sdebug_queue *sqp,
                         struct sdebug_queued_cmd *sqcp)
 {
-       if ((atomic_read(&sdebug_cmnd_count) % abs(sdebug_every_nth)) > 0)
+       if ((atomic_read(&sdebug_cmnd_count) % abs(sdebug_every_nth)) > 0) {
+               if (sdebug_every_nth > 0)
+                       sqcp->inj_recovered = sqcp->inj_transport
+                               = sqcp->inj_dif
+                               = sqcp->inj_dix = sqcp->inj_short = 0;
                return;
+       }
        sqcp->inj_recovered = !!(SDEBUG_OPT_RECOVERED_ERR & sdebug_opts);
        sqcp->inj_transport = !!(SDEBUG_OPT_TRANSPORT_ERR & sdebug_opts);
        sqcp->inj_dif = !!(SDEBUG_OPT_DIF_ERR & sdebug_opts);
-- 
2.16.1

Reply via email to