From: zhong jiang <zhongji...@huawei.com>

mempool_destroy has taken null pointer check into account. so remove the
redundant check.

Signed-off-by: zhong jiang <zhongji...@huawei.com>
Acked-by: Benjamin Block <bbl...@linux.ibm.com>
[ma...@linux.ibm.com: depends on v4.3 4e3ca3e033d1 ("mm/mempool: allow NULL 
`pool' pointer in mempool_destroy()")]
Signed-off-by: Steffen Maier <ma...@linux.ibm.com>
---
 drivers/s390/scsi/zfcp_aux.c | 21 +++++++--------------
 1 file changed, 7 insertions(+), 14 deletions(-)

diff --git a/drivers/s390/scsi/zfcp_aux.c b/drivers/s390/scsi/zfcp_aux.c
index 08cdc00e8299..8818a3a290f6 100644
--- a/drivers/s390/scsi/zfcp_aux.c
+++ b/drivers/s390/scsi/zfcp_aux.c
@@ -251,20 +251,13 @@ static int zfcp_allocate_low_mem_buffers(struct 
zfcp_adapter *adapter)
 
 static void zfcp_free_low_mem_buffers(struct zfcp_adapter *adapter)
 {
-       if (adapter->pool.erp_req)
-               mempool_destroy(adapter->pool.erp_req);
-       if (adapter->pool.scsi_req)
-               mempool_destroy(adapter->pool.scsi_req);
-       if (adapter->pool.scsi_abort)
-               mempool_destroy(adapter->pool.scsi_abort);
-       if (adapter->pool.qtcb_pool)
-               mempool_destroy(adapter->pool.qtcb_pool);
-       if (adapter->pool.status_read_req)
-               mempool_destroy(adapter->pool.status_read_req);
-       if (adapter->pool.sr_data)
-               mempool_destroy(adapter->pool.sr_data);
-       if (adapter->pool.gid_pn)
-               mempool_destroy(adapter->pool.gid_pn);
+       mempool_destroy(adapter->pool.erp_req);
+       mempool_destroy(adapter->pool.scsi_req);
+       mempool_destroy(adapter->pool.scsi_abort);
+       mempool_destroy(adapter->pool.qtcb_pool);
+       mempool_destroy(adapter->pool.status_read_req);
+       mempool_destroy(adapter->pool.sr_data);
+       mempool_destroy(adapter->pool.gid_pn);
 }
 
 /**
-- 
2.16.4

Reply via email to