On 7/27/19 5:37 AM, Douglas Gilbert wrote:
> The internal struct sg_comm_wr_t was added when the number of
> arguments to sg_common_write() became excessive. Expand this idea
> so multiple calls to sg_fetch_cmnd() can be deferred until a
> scsi_request object is ready to receive the command. This saves
> a 252 byte stack allocation on every submit path. Prior to this
> and a few other changes, the kernel infrastructure was warning
> about excessive stack usage.
> 
> Signed-off-by: Douglas Gilbert <dgilb...@interlog.com>
> ---
>  drivers/scsi/sg.c | 178 ++++++++++++++++++++++++----------------------
>  1 file changed, 92 insertions(+), 86 deletions(-)
> 
Reviewed-by: Hannes Reinecke <h...@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Teamlead Storage & Networking
h...@suse.de                                   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)

Reply via email to