On Friday 10 August 2007, Felipe Balbi wrote: >Better indentation
I don't think so. This whole patch seems to make one type of change: > - unsigned char St_ModeID; > - unsigned short St_ModeFlag; > - unsigned char St_StTableIndex; > - unsigned char St_CRT2CRTC; > - unsigned char St_ResInfo; > - unsigned char VB_StTVFlickerIndex; > - unsigned char VB_StTVEdgeIndex; > - unsigned char VB_StTVYFilterIndex; > - unsigned char St_PDC; ... all neatly indented so the fields line up. TheProblemISeeWithThatCodeIsThatItUsesCamelCase. > + unsigned char St_ModeID; > + unsigned short St_ModeFlag; > + unsigned char St_StTableIndex; > + unsigned char St_CRT2CRTC; > + unsigned char St_ResInfo; > + unsigned char VB_StTVFlickerIndex; > + unsigned char VB_StTVEdgeIndex; > + unsigned char VB_StTVYFilterIndex; > + unsigned char St_PDC; ... the fields stopped lining up. In that particular stretch it's not all that much worse, although it does seem harder to find the member names. However, overall I couldn't agree this is an improvement. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
