On Wed, Mar 17, 2004 at 04:01:52PM -0800, Greg KH wrote: > ChangeSet 1.1290.15.4, 2004/02/02 14:36:26-08:00, [EMAIL PROTECTED] > > [PATCH] USB: Fixing HID support for non-explicitly specified usages > > > drivers/usb/hid-core.c | 11 +++++- > drivers/usb/hiddev.c | 78 +++++++++++++++++++++++++++++++++---------------- > include/linux/hiddev.h | 75 +++++++++++++++++++++++++++-------------------- > 3 files changed, 107 insertions(+), 57 deletions(-) [skip]
This thing is seriously broken, both for 2.4.x and 2.6.x: 1) Allocating "struct hiddev_usage_ref_multi uref_multi" on the stack in hiddev_ioctl() is not good - with HID_MAX_USAGES==1024, it is more than 4K. 2) #include <linux/hiddev.h> from userspace no longer works: first, HID_MAX_USAGES definition is in a private header file; second, #include <asm/types.h> is needed for __s32 and the like. http://bugme.osdl.org/show_bug.cgi?id=2419
pgp00000.pgp
Description: PGP signature
