On Saturday 29 April 2006 17:48, Alan Stern wrote: > On Sat, 29 Apr 2006, Phil Dibowitz wrote: > > Tangential question - you're making the decision for the user here, so > > more so than "Why does Pete want to drive his iPod with ub", why does > > this make sense for everyone who uses Linux? > > Phil, I think you have misunderstood the point of this patch. It doesn't > make any decisions for the user. Just the opposite. > > The way libusual currently works is that every entry in unusual_devs.h is > automatically directed to usb-storage, not to ub. The patch adds a way to > specify that a particular entry should be directed according to the user's > preference, by coding such entries with the UNUSUAL_DEV2 macro instead of > UNUSUAL_DEV. > > Even for such entries, the default is still to direct them to usb-storage. > (Unless the last field in UNUSUAL_DEV2 is set to USB_US_TYPE_UB, which the > patch does not do.) Only if the user explicitly requests it will libusual > switch over to using ub. > > > > +#define UNUSUAL_DEV2(id_vendor, id_product, bcdDeviceMin, > > > bcdDeviceMax, \ + vendorName, productName, useProtocol, > > > useTransport, \ > > > + initFunction, flags, useType) \ > > > +{ USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin,bcdDeviceMax), \ > > > + .driver_info = (flags)|((useType)<<24) } > > > > UNUSUAL_DEV2?! Ew. How about UNUSUAL_DEV_UB? > > I agree that UNUSUAL_DEV2 is not the best name. But UNUSUAL_DEV_UB is > even worse, because these entries are not automatically directed to ub. > I'm not sure what a better name might be. USUAL_DEV? That looks rather > peculiar.
UNUSUAL_DEV_AUTO? (Because it auto-selects the driver) -- Regards, Christian Iversen ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel