> This does far too much to be a single patch.  It needs to be broken up.

Agreed.  300+ KB is not digestible at all.

Most maintainers like to see patches on the order of 10 KB; that much
is easy to review.  New drivers are rarely that small of course, but
that should give you some understanding of just how excessive this is...

But the fact that this one "driver" patch touched so many other files
outside its own directory is a dead giveaway that it's got something
pretty wrong...

- Dave


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to