On Tue, 2007-12-04 at 17:55 +0100, Matthias Kaehlcke wrote: > @@ -1990,7 +1991,7 @@ static void usbtest_disconnect (struct > usb_interface *intf) > { > struct usbtest_dev *dev = usb_get_intfdata (intf); > > - down (&dev->sem); > + mutex_lock(&dev->lock); > > usb_set_intfdata (intf, NULL); > dev_dbg (&intf->dev, "disconnect\n");
This looks like a bit of an anomaly.. The code that isn't shown above is the "kfree(dev)" .. So this isn't legal since it's freeing a locked mutex. Here's a excerpt from the comment above mutex_lock(), * The mutex must later on be released by the same task that * acquired it. Recursive locking is not allowed. The task * may not exit without first unlocking the mutex. Also, kernel * memory where the mutex resides mutex must not be freed with * the mutex still locked. The mutex must first be initialized * (or statically defined) before it can be locked. memset()-ing * the mutex to 0 is not allowed. Daniel ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ Linux-usb-users@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-users