On Wed, 2007-07-25 at 16:21 +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2007-07-25 at 11:57 +0900, Ishizaki Kou wrote:
> > This patch cleans up xmon to keep consistency.
> >
> > In xmon, we should use console I/O functions that are named the same
> > as user space stdio functions. But commit
> > 4d404edce30f911004850d472e05a31efd751662 broke this consistency.
> >
> > Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
> > ---
> >
> > Index: linux-powerpc-git/arch/powerpc/xmon/nonstdio.c
> > ===================================================================
> > --- linux-powerpc-git.orig/arch/powerpc/xmon/nonstdio.c
> > +++ linux-powerpc-git/arch/powerpc/xmon/nonstdio.c
> > @@ -133,7 +133,7 @@ void xmon_printf(const char *format, ...
> > xmon_write(xmon_outbuf, n);
> > }
> >
> > -void xmon_puts(const char *str)
> > +void xmon_fputs(const char *str)
> > {
> > xmon_write(str, strlen(str));
>
> Nah, keep it xmon_puts, since it doesn't take a stream argument and
> define a "puts" for use by xmon core.But then it needs to add a newline .. and we've gone around in a circle again. Funny how the trivialest of patches gets the most review. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Linuxppc-dev mailing list [email protected] https://ozlabs.org/mailman/listinfo/linuxppc-dev
