On Mon, Jan 05, 2009 at 10:25:08AM -0600, Kumar Gala wrote: > > On Jan 5, 2009, at 4:47 AM, Li Yang wrote: > > >Probe the new mdio node added by b31a1d8b. Fix kernel panic problem > >when > >gianfar driver wants to get the of_platform_device of that mdio. > > > >Signed-off-by: Li Yang <[email protected]> > >--- > >arch/powerpc/boot/dts/mpc8313erdb.dts | 2 +- > >1 files changed, 1 insertions(+), 1 deletions(-) > > > >diff --git a/arch/powerpc/boot/dts/mpc8313erdb.dts b/arch/powerpc/ > >boot/dts/mpc8313erdb.dts > >index d4df8b6..917d466 100644 > >--- a/arch/powerpc/boot/dts/mpc8313erdb.dts > >+++ b/arch/powerpc/boot/dts/mpc8313erdb.dts > >@@ -222,7 +222,7 @@ > > cell-index = <1>; > > device_type = "network"; > > model = "eTSEC"; > >- compatible = "gianfar"; > >+ compatible = "gianfar", "simple-bus"; > > reg = <0x25000 0x1000>; > > local-mac-address = [ 00 00 00 00 00 00 ]; > > interrupts = <34 0x8 33 0x8 32 0x8>; > > This isn't correct at all. Not sure what the panic is but adding > "simple-bus" isn't correct.
It looks like the mdio node got added in the wrong place on 8313erdb, relative to where it went on all other boards -- though if we were to ignore existing practice, it probably does belong under the gianfar node (and not as a freestanding device). -Scott _______________________________________________ Linuxppc-dev mailing list [email protected] https://ozlabs.org/mailman/listinfo/linuxppc-dev
