On 16/06/2010, at 22:07 , Gaetan Nadon wrote:
> On Wed, 2010-06-16 at 13:53 +1000, Peter Hutterer wrote:
>> On Tue, Jun 15, 2010 at 09:54:41PM -0400, Gaetan Nadon wrote:
>> > Since commit a83cff9f4d622b069c96a68b4e87a669bf1f6446
>> >
>> > Fields x and y have been added to ScreenRec.
>> >
>> > Signed-off-by: Gaetan Nadon <
>> mems...@videotron.ca
>> >
>> > ---
>> > src/wcmCommon.c | 8 ++++----
>> > 1 files changed, 4 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/src/wcmCommon.c b/src/wcmCommon.c
>> > index 4a70195..9370744 100644
>> > --- a/src/wcmCommon.c
>> > +++ b/src/wcmCommon.c
>> > @@ -1791,10 +1791,10 @@ void wcmInitialScreens(LocalDevicePtr local)
>> > {
>> > if (screenInfo.numScreens > 1)
>> > {
>> > - priv->screenTopX[i] = dixScreenOrigins[i].x;
>> > - priv->screenTopY[i] = dixScreenOrigins[i].y;
>> > - priv->screenBottomX[i] = dixScreenOrigins[i].x;
>> > - priv->screenBottomY[i] = dixScreenOrigins[i].y;
>> > + priv->screenTopX[i] = screenInfo.screens[i]->x;
>> > + priv->screenTopY[i] = screenInfo.screens[i]->y;
>> > + priv->screenBottomX[i] = screenInfo.screens[i]->x;
>> > + priv->screenBottomY[i] = screenInfo.screens[i]->y;
>> >
>> > DBG(10, priv, "from dix: "
>> > "ScreenOrigins[%d].x=%d ScreenOrigins[%d].y=%d
>> > \n",
>> > --
>> > 1.6.0.4
>> >
>> > Found due to compile error. Please check as I cannot do a live test.
>>
>> This isn't quite as easy. Adding this patch means that the driver won't
>> build against earlier versions of the server anymore because x/y are missing
>> from the ScreenRec. Thanks to the video ABI not being bumped after/with this
>> change, there is no easy way around this, afaict.
>>
>>
> Should that not be considered a bug in the server? If so, there should still
> be time to bump the ABI or whatever has to be done. RC1 was released
> yesterday I think. This type of change must be breaking some rule in the
> server development process or there is a big hole in it.
yes and no, there's some disagreement. Keith generally thinks that bumping the
ABI once per cycle is enough. For the input API, I've asked him to bump
multiple times if needed to avoid this situation.
This one I picked up quite late because I was busy with the 1.8 branch and only
realized a while later. I'm not happy about it but afaict the wacom driver is
the only affected driver - at least I haven't heard anyone else complain yet.
We could probably still bump the ABI but right now I'm wondering if we even
need the information in the driver. From my current tests, ripping out all
multi-screen stuff provides better results than the current code.
Cheers,
Peter
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
