>> Should it be modifiable? I'm unsure. It would be easier to code if it were always > 0, but there is a nicety to having it negative when only a few iterations of the file are being kept. That said, I would have no problem removing it as a configuration parameter.
>>+1, but one should be able to change the "spacer" character. "." is a nuisance to regex >>parse a logfile, where "-" is tangentially easier. Create a new DatePatternSeperator parameter that could be one or more characters. It could default to "." or "-" (as we see fit). It would simply be placed to the left of resulting date before the resulting date is injected into the file name. >><rollFilePattern value="##" /> <!-- see string.Format() --> The idea behind the fixed width field was to make finding the rolled files easier. Going to a ## type format would defeat that purpose. Allowing the user to specify a format would give them great flexibility, but would create yet more cases when rolling would fail simply because of the difficulty in determining the resultant file names. I am not sure that I can support a user defined format for a code point of view. >> What does it anyway? Enlighten me, please! :-) If true for size based rolling the current file is always the value of the File parameter and then the file is renamed to File.xx or File.xx.ext as needed. Otherwise the current file has its final name if countdirection is positive. For a date based rolling the file is renamed with its date portion appended and that is why the sample configuration from the bug report fails. The current code does not and has no reasonable way to detect the 'file name' in the DatePattern parameter. While having the fixed file name is great for humans because they can easily find it in the file list, it is terrible for performance and programs that might want to process the file list. I do not have an opinion one way or the other on your proposal for the "grouped" roll configuration. Please explain your reasoning for your preference so that I might understand better. ---------------------------------------------------------------------- Roy Chastain
