On Sunday 06 April 2008, Li Zefan wrote:
> > sched_rr_get_interval02 fails most of the time Private: (?)
> > No
> > i cant seem to narrow this down, but most of the time,
> > sched_rr_get_interval02 fails
> >
> > # ./sched_rr_get_interval02
> > sched_rr_get_interval02 1 FAIL : Test Failed,
> > sched_rr_get_interval()returned 0, errno = 0 : Success, tp.tv_sec = 3,
> > tp.tv_nsec = 464216500
> >
> > unfortunately, i havent been able to get an strace of a successful run
>
> Recently we fixed a bug in sched_rr_get_interval that
> sched_rr_get_interval() may or may not return 0 for SCHED_FIFO (that
> depends on the calculation of the else brance):
>
> commit 1868f958eb56fc41c5985c8732e564a400c5fdf5
> Author: Miao Xie <[EMAIL PROTECTED]>
> Date: Fri Mar 7 09:35:06 2008 +0800
>
> sched: fix the wrong time slice value for SCHED_FIFO tasks
>
> Function sys_sched_rr_get_interval returns wrong time slice value for
> SCHED_FIFO tasks. The time slice for SCHED_FIFO tasks should be 0.
>
> Signed-off-by: Miao Xie <[EMAIL PROTECTED]>
> Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
>
> diff --git a/kernel/sched.c b/kernel/sched.c
> index 63a469f..5b13e4b 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -5100,7 +5100,7 @@ long sys_sched_rr_get_interval(pid_t pid, struct
> timespec __user *interval) time_slice = 0;
> if (p->policy == SCHED_RR) {
> time_slice = DEF_TIMESLICE;
> - } else {
> + } else if (p->policy != SCHED_FIFO) {
> struct sched_entity *se = &p->se;
> unsigned long flags;
> struct rq *rq;thanks, this does seem to be the problem. i applied the fix to Blackfin/2.6.24.3 and i cant get it to fail now. -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Register now and save $200. Hurry, offer ends at 11:59 p.m., Monday, April 7! Use priority code J8TLD2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
