On Tue, Aug 17, 2010 at 3:51 PM, Garrett Cooper wrote:
> On Tue, Aug 17, 2010 at 9:42 AM, Mike Frysinger wrote:
>> On Tue, Aug 17, 2010 at 12:31 PM, Garrett Cooper wrote:
>>> Let me know how this patch works for you.
>>
>> the logic in lib/Makefile should be unified with this
>
> lib.mk picks up env_post.mk, so it's already caught there. Or are you
> referring to how libltp is built and what headers are picked up from
> include/ ?

i mean there should not be more than one place in the whole tree which
adds -DUCLINUX/etc...  if we merge your patch, there will be.  i'm not
saying your patch is wrong, just that something needs fixing to avoid
the aforementioned scenario.
-mike

------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to