2010/8/18 Mitani <[email protected]>: > Hi, > > I tried to build open_posix_testsuite testcases with latest git: > ltp-dev-e8ad463baada21fb19f4c06f7dcab75c420ae373.tar.gz > > Several testcases failed to build. > Two of them is as follows: > ------------ > [...] > conformance/interfaces/pthread_attr_setstack/2-1 compile FAILED > In file included from > ../../../conformance/interfaces/pthread_attr_setstack/2-1.c:31: > ../../../include/posixtest.h:14:2: error: #error "Contains GNU-isms that > need fixing." > [...] > conformance/interfaces/pthread_attr_setstacksize/2-1 compile FAILED > In file included from > ../../../conformance/interfaces/pthread_attr_setstacksize/2-1.c:31: > ../../../include/posixtest.h:14:2: error: #error "Contains GNU-isms that > need fixing." > [...] > ------------ > > ".../pthread_attr_setstack/2-1.c" and ".../include/posixtest.h" are > as follows: > ------------(.../pthread_attr_setstack/2-1.c) > [...] > #ifndef _GNU_SOURCE > #define _GNU_SOURCE > #endif > #include <pthread.h> > #include <limits.h> > #include <stdio.h> > #include <string.h> > #include <stdlib.h> > #include <sys/param.h> > #include <errno.h> > #include <unistd.h> > #include "posixtest.h" > [...] > ------------ > > ------------(posixtest.h) > [...] > #if defined(_GNU_SOURCE) > #error "Contains GNU-isms that need fixing." > #elif defined(_BSD_SOURCE) > #error "Contains BSD-isms that need fixing." > #endif > [...] > ------------ > > In above "2-1.c", "_GNU_SOURCE" is defined. After that, "posixtest.h" > is included. > And, in "posixtest.h", if "_GNU_SOURCE" is defined, error occurs. > > If "#ifndef _GNU_SOURCE" is arranged after a line of "posixtest.h", > error doesn't occur. > I confirmed that build succeeded by this revision and the test > became PASS. > > Another "2-1.c" is same as above testcase. > > > Signed-off-by: Tomonori Mitani <[email protected]> > > ============ > --- > a/testcases/open_posix_testsuite/conformance/interfaces/pthread_attr_setstac > k/2-1.c 2010-08-18 07:18:35.000000000 +0900 > +++ > b/testcases/open_posix_testsuite/conformance/interfaces/pthread_attr_setstac > k/2-1.c 2010-08-18 15:43:16.000000000 +0900 > @@ -17,9 +17,6 @@ > * provided by nptl, which is developed by Ulrich Drepper. > */ > > -#ifndef _GNU_SOURCE > -#define _GNU_SOURCE > -#endif > #include <pthread.h> > #include <limits.h> > #include <stdio.h> > @@ -30,6 +27,10 @@ > #include <unistd.h> > #include "posixtest.h" > > +#ifndef _GNU_SOURCE > +#define _GNU_SOURCE > +#endif > + > #define TEST "2-1" > #define FUNCTION "pthread_attr_setstack" > #define ERROR_PREFIX "unexpected error: " FUNCTION " " TEST ": " > --- > a/testcases/open_posix_testsuite/conformance/interfaces/pthread_attr_setstac > ksize/2-1.c 2010-08-18 07:18:35.000000000 +0900 > +++ > b/testcases/open_posix_testsuite/conformance/interfaces/pthread_attr_setstac > ksize/2-1.c 2010-08-18 15:44:56.000000000 +0900 > @@ -17,9 +17,6 @@ > * provided by nptl, which is developed by Ulrich Drepper. > */ > > -#ifndef _GNU_SOURCE > -#define _GNU_SOURCE > -#endif > #include <pthread.h> > #include <limits.h> > #include <stdio.h> > @@ -30,6 +27,10 @@ > #include <unistd.h> > #include "posixtest.h" > > +#ifndef _GNU_SOURCE > +#define _GNU_SOURCE > +#endif > + > #define TEST "2-1" > #define FUNCTION "pthread_attr_setstacksize" > #define ERROR_PREFIX "unexpected error: " FUNCTION " " TEST ": "
This is intentional :). The tests need to be written to use only POSIX compliant APIs. Otherwise, it isn't truly POSIX compliant. Thanks, -Garrett ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
