Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> * InsetBase and all derivates: - metrics(MetricsInfo & mi,
Abdelrazak> Dimension & dim) now returns a bool (true if metrics
Abdelrazak> changed).
All these changes make me wonder whether the caller could test by
itself whether the metrics have changed. But I guess you thought about
that too and the meaning is more profound.
Actually yes. I considered doing what you suggest but then I asked
myself: why do we pass the Dimension variable? Is that needed in all
cases? Do we really need absolute coordinates inside insets?
Anyway, I came up with the conclusion that returning a bool is the less
risky change for now as it won't affect the code that does not make use
of it. Additionally, I would like to split the metrics() method like
this way:
bool updateMetrics(MetricsInfo & mi);
Dimension const & dimension();
Hope my logic makes sense.
Abdel.
