Jürgen Spitzmüller wrote:
I'll comment only on those that I haven't approved last time.
http://www.lyx.org/trac/changeset/20016 - optimization: avoid some font
copying
http://www.lyx.org/trac/changeset/20021 - enable some non-rtl optimization
Alfredo asked for some expert review. After that, it can go in.
(I've already approved that)
They are safe IMHO.
New
---
http://www.lyx.org/trac/changeset/19867 - InsetCollapsable::setStatus():
remove the Buffer::changed() signal emission
Already approved last time ...
Yes, I know I promised to do that last time but I was waiting for my
other patch to be committed. I'll try to backport it but this just a
cosmetics change for branch, nothing critical.
http://www.lyx.org/trac/changeset/19919 - Fix DEPM crash within inset.
always clear the full text_metrics_ when doing a full update.
Applicable to branch?
In theory yes but this will have side effects within insets. OTOH, that
may solve some of the not easily reproducible crashes that have been
reported.
http://www.lyx.org/trac/changeset/20102 - Fix y co-ordinate for
Conglomerate-style inset
http://www.lyx.org/trac/changeset/20103 - y-coord in Conglomerate, this
time properly
Not applicable to branch, I think. Remove both.
Right.
http://www.lyx.org/trac/changeset/20159 - remove recursive call
Hm. Peter, is this something for branch?
No.
http://www.lyx.org/trac/changeset/20081 - TextMetrics::drawSelection():
use parMetrics() instead of direct access just in case. Should fix crash
on selection with PageUp
Abdel?
No.
http://www.lyx.org/trac/changeset/20082 - Fix drawing of collapsable
inset without button.
Not applicable to branch, I think. Remove.
Right.
http://www.lyx.org/trac/changeset/20083 - Fix alignment of text within
insets.
http://www.lyx.org/trac/changeset/20101 - Nicely align inset buttons
with surrounding text.
http://www.lyx.org/trac/changeset/20142 - Restore docked View source
widget. http://www.lyx.org/trac/changeset/20143 - fix view source window
title. http://www.lyx.org/trac/changeset/20144 - oups...
http://www.lyx.org/trac/changeset/20146 - Dialog::name() is not really
needed.
http://www.lyx.org/trac/changeset/20147 - Restore docked outline widget.
Warning: still instable!
http://www.lyx.org/trac/changeset/20177 - TextMetrics::draw(): withdraw
first row ascent before drawing because the convention is that the
baseline of a multirow text is the baseline of the first row.
http://www.lyx.org/trac/changeset/20178 - fix outline dialog for non-Mac
platform.
All not applicable to branch, I think. Remove.
And right.
Abdel.
