> >> not regress for everyone. imo.
> >
> > well now the status is we have regression of 1.5.3 to 1.5.2 for some
> > users.
>
> some = (small) minority, as well as creating a much better user-experience
> for the rest.
continuing this way we can one day conclude that we should stop support linux
platform as 99% people use much better user-experience win.
the following patch is ugly but i dont see many other ways compared to reverting
the xdg stuff. i'm no pythonist so somebody should look it over.
Juergen you are the 1.5 chief, what you think ?
pavel
Index: configure.py
===================================================================
--- configure.py (revision 22413)
+++ configure.py (working copy)
@@ -8,7 +8,7 @@
# \author Bo Peng
# Full author contact details are available in file CREDITS.
-import sys, os, re, shutil, glob
+import sys, os, re, shutil, glob, commands
class Tee:
@@ -178,9 +178,28 @@
addToRC(rc_entry[-1].replace('%%', not_found))
return ['', not_found]
+def detectDE():
+ '''
+ Check for desktop environment. Needed for xdg-open which
+ has awful behaviour in case no DE is detected.
+ '''
+ DE = 0
+ if os.environ.get("KDE_FULL_SESSION"):
+ DE = 1
+ else:
+ if os.environ.get("GNOME_DESKTOP_SESSION_ID"):
+ DE = 1
+ else:
+ if commands.getoutput("pidof xfce-mcs-manage") != "":
+ DE = 1
+ return DE
def checkViewer(description, progs, rc_entry = [], path = []):
''' The same as checkProg, but for viewers and editors '''
+ if not detectDE():
+ if ("xdg-open" in progs):
+ progs.remove("xdg-open")
+
return checkProg(description, progs, rc_entry, path, not_found = 'auto')
