On 10/07/2017 09:30 PM, Scott Kostyshak wrote: > On Sat, Oct 07, 2017 at 10:39:37PM +0000, Richard Heck wrote: >> On 10/07/2017 06:15 PM, Scott Kostyshak wrote: >>> On Sat, Oct 07, 2017 at 02:16:39PM +0000, Richard Heck wrote: >>> >>>> Probably more for master, as there is a simpler solution for 2.3.x. But >>>> it would be good >>>> to test it. >>> Do you have a patch for the simpler solution that I can test for 2.3.x? >> Attached. > Works well in brief testing. Can someone who understand the code +1 so > Richard can push to 2.3.x?
For what it's worth, this is super-safe. The cursor will be reset after the document reloads, anyway, and it will be invalid once reload starts. So any attempt to use it would be fatal. For that reason, I think we should probably do this here even if we also commit the other patch. Any other cursors that might be attached to other BufferViews will also be invalid, but I'm not sure how to find them, and presumably they won't matter so much. Richard
