Am Dienstag, den 07.08.2018, 12:29 -0400 schrieb Scott Kostyshak:
> To Jürgen: I don't expect you to fix these. You've already done so
> much
> work on this. I just provide this feedback since I am trying out
> these
> insets for the first time (I'm on master at 781b1030). I can make
> trac
> tickets if anyone suggests.

Thanks for testing. I will respond in the kind of first thoughts:

> 1. If I insert Field > User Name, then change the name in Preferences
> and click "OK" or "Apply", the inset is not updated in the LyX
> display
> until I do something like <Return>. I think this behavior is more
> general than this specific inset (e.g., I remember a similar issue
> with
> Instant Preview), but since I noticed it here I report it here.

It actually updates if you click on the inset, so I suppose a prefs
apply should trigger a buffer update.

> 2. When I first went to Inset > Field > User name, I wasn't sure
> whether
> my computer user name, or my LyX user name would show up. When I go
> to
> the inset settings, it is clear because it is in the category "LyX
> Preferences Entry", but just from the menus, it was not clear to me.
> We
> could change the menu entry to "LyX user name" and "LyX user email",
> but
> unless someone also had the same uncertainty that I did, this is
> probably a "wontfix".

I don't like "LyX user name", but I am open for good suggestions. In
any case, I wanted to differentiate it from "Author", which can differ.

> 3. I find the category name "All Keyboard Shortcuts" inconsistent
> with
> the other category names. For example, there is "LyX Preferences
> Entry",
> not "All LyX Preferences Entry". I think the intent was to
> differentiate
> the category from the closely related "Last Assigned Keyboard
> Shortcut"
> (which I don't actually know what this one does). Perhaps we could
> change "All Keyboard Shortcuts" to "Keyboard Shortcuts"?

There are two info types here: one only displays the last shortcut in
the list of potentially multiple shortcuts assigned to a function, the
other displays the whole list.

There is no such thing for preferences entries.

So "All keyboard shortcuts" means "All shortcuts for the function
selected", not "display all keyboard shortcuts in the dialog". I think
removing the "all" does not make it more transparent.

> 4. If I do Insert > Field > Other, the "immediate apply" checkbox is
> enabled. I wonder if it should only be enabled if we are editing an
> inset (rather than creating a new one)?

It's only enabled if you had it enabled. We save the state for all
dialogs. I don't think we should make an exception here.

> 5. What is the purpose of having the "Unknown" option in the combo
> box?
> I imagine it has a use, but would it make sense to internally allow
> the
> combo box to be set to that value, but just not provide it as an
> option
> in the interface? I guess what I'm asking is: would a user ever want
> to
> manually set the value to "Unknown"?

No. I am not sure, though, that we can add a hidden item to the combo.

> 6. I get the following warning:
> frontends/qt4/Menus.cpp (763): Menu warning: menu entries "Index
> Entry|d" and "Field|d" share the same shortcut.

OK, this comes from one of the dynamic menu parts. You only get it if
you have an index. That's why I missed it.

> 7. Are we concerned about any security/privacy issues related to this
> feature? This item is not really relevant to the recent changes,
> since
> some (all?) of this information was already available. I don't have
> any
> particular concern here, but since we are exposing e.g. LyX user
> name,
> LyX user email, and LyX preferences, I'm curious if someone can think
> of
> a privacy issue. The biggest "security threat" I could think of is if
> I'm helping someone who sends me a .lyx file and asks me to send them
> the corresponding .pdf, perhaps I don't expect that my "LyX user
> name"
> (which I think defaults to my computer's user name) could be
> contained.
> I suppose that knowing one's computer name makes it easier to e.g.
> SSH
> into their box. This is not a personal concern of mine, and I expose
> my
> computer user name and host name all over the place. I was just
> attempting to think of what might be a concern to other LyX users.

I think due to this security issue we do not set the user name
automatically. Users need to deliberately set it. I don't think it is
related to the computer name.

Jürgen

> 
> I am enjoying this new feature. I think I will find some nice uses
> for
> it in my work.
> 
> Best,
> 
> Scott

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to