------------------------------------------------------------
revno: 6667
committer: Barry Warsaw <[email protected]>
branch nick: 3.0
timestamp: Tue 2009-01-06 21:35:00 -0500
message:
Update some comments.
modified:
mailman/core/logging.py
mailman/testing/layers.py
=== modified file 'mailman/core/logging.py'
--- a/mailman/core/logging.py 2009-01-05 00:41:05 +0000
+++ b/mailman/core/logging.py 2009-01-07 02:35:00 +0000
@@ -40,6 +40,17 @@
+# XXX I would love to simplify things and use Python 2.6's WatchedFileHandler,
+# but there are two problems. First, it's more difficult to handle the test
+# suite's need to reopen the file handler to a different path. Does
+# zope.testing's logger support fix this?
+#
+# The other problem is that WatchedFileHandler doesn't really easily support
+# HUPing the process to reopen the log file. Now, maybe that's not a big deal
+# because the standard logging module would already handle things correctly if
+# the file is moved, but still that's not an interface I'm ready to give up on
+# yet. For now, keep our hack.
+
class ReopenableFileHandler(logging.Handler):
"""A file handler that supports reopening."""
=== modified file 'mailman/testing/layers.py'
--- a/mailman/testing/layers.py 2009-01-07 00:55:59 +0000
+++ b/mailman/testing/layers.py 2009-01-07 02:35:00 +0000
@@ -87,8 +87,7 @@
level: debug
""")
# Enable log message propagation and reset the log paths so that the
- # doctests can check the output. XXX Switch to using the log support
- # in zope.testing.
+ # doctests can check the output.
for logger_config in config.logger_configs:
sub_name = logger_config.name.split('.')[-1]
if sub_name == 'root':
--
Primary development focus
https://code.launchpad.net/~mailman-coders/mailman/3.0
You are receiving this branch notification because you are subscribed to it.
_______________________________________________
Mailman-checkins mailing list
[email protected]
Unsubscribe:
http://mail.python.org/mailman/options/mailman-checkins/archive%40jab.org
