------------------------------------------------------------
revno: 1280
committer: Mark Sapiro <[email protected]>
branch nick: 2.1
timestamp: Mon 2011-02-07 12:42:05 -0800
message:
  - Fixed an uncaught KeyError when poster tries to cancel a post which was
    already handled.  Bug #266224.
modified:
  Mailman/Cgi/confirm.py
  NEWS


--
lp:mailman/2.1
https://code.launchpad.net/~mailman-coders/mailman/2.1

Your team Mailman Checkins is subscribed to branch lp:mailman/2.1.
To unsubscribe from this branch go to 
https://code.launchpad.net/~mailman-coders/mailman/2.1/+edit-subscription
=== modified file 'Mailman/Cgi/confirm.py'
--- Mailman/Cgi/confirm.py	2010-03-29 20:48:11 +0000
+++ Mailman/Cgi/confirm.py	2011-02-07 20:42:05 +0000
@@ -1,4 +1,4 @@
-# Copyright (C) 2001-2010 by the Free Software Foundation, Inc.
+# Copyright (C) 2001-2011 by the Free Software Foundation, Inc.
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License
@@ -634,6 +634,7 @@
         try:
             # Do this in two steps so we can get the preferred language for
             # the user who posted the message.
+            subject = 'n/a'
             op, id = mlist.pend_confirm(cookie)
             ign, sender, msgsubject, ign, ign, ign = mlist.GetRecord(id)
             lang = mlist.getMemberLanguage(sender)
@@ -644,7 +645,7 @@
             # Discard the message
             mlist.HandleRequest(id, mm_cfg.DISCARD,
                                 _('Sender discarded message via web.'))
-        except Errors.LostHeldMessage:
+        except (Errors.LostHeldMessage, KeyError):
             bad_confirmation(doc, _('''The held message with the Subject:
             header <em>%(subject)s</em> could not be found.  The most likely
             reason for this is that the list moderator has already approved or

=== modified file 'NEWS'
--- NEWS	2011-02-07 20:09:54 +0000
+++ NEWS	2011-02-07 20:42:05 +0000
@@ -34,6 +34,9 @@
 
   Bug Fixes and other patches
 
+    - Fixed an uncaught KeyError when poster tries to cancel a post which was
+      already handled.  Bug #266224.
+
     - Held message user notifications now come From: list-owner instead of
       list-bounces.  Bug #714424.
 

_______________________________________________
Mailman-checkins mailing list
[email protected]
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-checkins/archive%40jab.org

Reply via email to