Bhargav has proposed merging lp:~bhargav-golla/postorius/bug-1294352 into
lp:postorius.
Commit message:
Fixes Bug 1294352
Requested reviews:
Mailman Coders (mailman-coders)
For more details, see:
https://code.launchpad.net/~bhargav-golla/postorius/bug-1294352/+merge/212171
This merge fixes Bug 1294352
--
https://code.launchpad.net/~bhargav-golla/postorius/bug-1294352/+merge/212171
Your team Mailman Coders is requested to review the proposed merge of
lp:~bhargav-golla/postorius/bug-1294352 into lp:postorius.
=== modified file 'src/postorius/views/user.py'
--- src/postorius/views/user.py 2014-03-15 21:36:39 +0000
+++ src/postorius/views/user.py 2014-03-21 14:32:17 +0000
@@ -257,15 +257,23 @@
user = MailmanUser(display_name=form.cleaned_data['display_name'],
email=form.cleaned_data['email'],
password=form.cleaned_data['password'])
+ user_obj = None
try:
- user.save()
- except MailmanApiError:
- return utils.render_api_error(request)
- except HTTPError, e:
- messages.error(request, e)
+ user_obj = MailmanUser.objects.get(address=form.cleaned_data['email'])
+ except Mailman404Error:
+ user_obj = None
+ if user_obj is not None:
+ messages.error(request, _("User with this e-mail already registered"))
else:
- messages.success(request, _("New User registered"))
- return redirect("user_index")
+ try:
+ user.save()
+ except MailmanApiError:
+ return utils.render_api_error(request)
+ except HTTPError, e:
+ messages.error(request, e)
+ else:
+ messages.success(request, _("New User registered"))
+ return redirect("user_index")
else:
form = UserNew()
return render_to_response('postorius/users/new.html',
_______________________________________________
Mailman-coders mailing list
[email protected]
https://mail.python.org/mailman/listinfo/mailman-coders
