Aurélien Bompard has proposed merging lp:~abompard/mailman/bug-1170347 into lp:mailman.
Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~abompard/mailman/bug-1170347/+merge/242761 Fix digest handler crash reported in bug #1170347. -- Your team Mailman Coders is requested to review the proposed merge of lp:~abompard/mailman/bug-1170347 into lp:mailman.
=== added file 'src/mailman/handlers/tests/test_to_digest.py' --- src/mailman/handlers/tests/test_to_digest.py 1970-01-01 00:00:00 +0000 +++ src/mailman/handlers/tests/test_to_digest.py 2014-11-25 11:18:00 +0000 @@ -0,0 +1,63 @@ +# Copyright (C) 2012-2014 by the Free Software Foundation, Inc. +# +# This file is part of GNU Mailman. +# +# GNU Mailman is free software: you can redistribute it and/or modify it under +# the terms of the GNU General Public License as published by the Free +# Software Foundation, either version 3 of the License, or (at your option) +# any later version. +# +# GNU Mailman is distributed in the hope that it will be useful, but WITHOUT +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for +# more details. +# +# You should have received a copy of the GNU General Public License along with +# GNU Mailman. If not, see <http://www.gnu.org/licenses/>. + +"""Test the to_digest handler.""" + +from __future__ import absolute_import, print_function, unicode_literals + +__metaclass__ = type +__all__ = [ + 'TestToDigest', + ] + + +import unittest +import os + +from mailman.app.lifecycle import create_list +from mailman.testing.helpers import ( + get_queue_messages, + specialized_message_from_string as mfs) +from mailman.testing.layers import ConfigLayer + +from mailman.handlers.to_digest import ToDigest + + + +class TestToDigest(unittest.TestCase): + """Test the to_digest handler.""" + + layer = ConfigLayer + + def setUp(self): + self._mlist = create_list('[email protected]') + self._msg = mfs("""\ +From: [email protected] +To: [email protected] +Subject: A disposable message +Message-ID: <ant> + +""") + self._handler = ToDigest() + + def test_unicode_message(self): + self._msg.set_payload(b"non-ascii chars \xc3\xa9 \xc3\xa8 \xc3\xa7") + self._msg["X-Test"] = "dummy" + self._handler.process(self._mlist, self._msg, {}) + # Make sure the digest mbox is not empty + mailbox_path = os.path.join(self._mlist.data_path, 'digest.mmdf') + self.assertNotEqual(os.path.getsize(mailbox_path), 0) === modified file 'src/mailman/handlers/to_digest.py' --- src/mailman/handlers/to_digest.py 2014-01-01 14:59:42 +0000 +++ src/mailman/handlers/to_digest.py 2014-11-25 11:18:00 +0000 @@ -55,7 +55,7 @@ mailbox_path = os.path.join(mlist.data_path, 'digest.mmdf') # Lock the mailbox and append the message. with Mailbox(mailbox_path, create=True) as mbox: - mbox.add(msg) + mbox.add(msg.as_string()) # Calculate the current size of the mailbox file. This will not tell # us exactly how big the resulting MIME and rfc1153 digest will # actually be, but it's the most easily available metric to decide
_______________________________________________ Mailman-coders mailing list [email protected] https://mail.python.org/mailman/listinfo/mailman-coders
