Pavan Koli has proposed merging lp:~pskoli93/postorius/list-name-limit into 
lp:postorius.

Requested reviews:
  Mailman Coders (mailman-coders)

For more details, see:
https://code.launchpad.net/~pskoli93/postorius/list-name-limit/+merge/256734

A maximum character limit is necessary for name of the list, here a limit of 
100 characters has been proposed to the list name.

A folder corresponding to the list-name@domain is created at the path 
mailam/var/lists. There is character limit on the name that can be given for 
path and file(more info- http://stackoverflow.com/a/6571568/3601099, 
http://unix.stackexchange.com/a/29001).

If we specify a very long name suppose exceeding 150 characters during the 
creation of the folder an error arises with the makedir() which leads to a HTTP 
500 error.
-- 
Your team Mailman Coders is requested to review the proposed merge of 
lp:~pskoli93/postorius/list-name-limit into lp:postorius.
=== modified file 'src/postorius/forms.py'
--- src/postorius/forms.py	2015-04-17 21:51:29 +0000
+++ src/postorius/forms.py	2015-04-18 09:59:54 +0000
@@ -98,7 +98,7 @@
     Form fields to add a new list. Languages are hard coded which should
     be replaced by a REST lookup of available languages.
     """
-    listname = forms.CharField(
+    listname = forms.CharField(max_length=100,
         label=_('List Name'),
         required=True,
         error_messages={'required': _('Please enter a name for your list.'),

_______________________________________________
Mailman-coders mailing list
[email protected]
https://mail.python.org/mailman/listinfo/mailman-coders

Reply via email to