Actually I'm in favor of getters and setters, XPath is so hellish error prone that I would prefer that noone needs to touch it ;) But I never really figured out if getters and setters are part of the model of the tool in an MVC approach. Having Getters and Setters would make it easier to create an APi at one point in time. But this is a different discussion.
Steven On Jul 23, 2007, at 10:23 PM, Cameron Shorter wrote: > I'm +1 for removing placeholder models. > I also think that models usually shouldn't have setter/getter > methods as it adds code and the tools that use the models can > generally set/get using Xpath. > > Steven M. Ottens wrote: >> In general I'm not in favor of shipping empty models that are >> merely placeholders for future models to come. On the other hand >> if there are no placeholders, people will never know that these >> models are there to be expanded. So if we keep them, we need to >> make clear that they need work and preferably what this work is. >> This would make it easy for new developers to extent mapbuilder >> since it's clear what tasks there are. >> So I do have a favor of moving them, but keeping them together >> with some extra information what their purpose should be and what >> needs to be added is fine by me as well. >> >> STeven >> >> On Jul 23, 2007, at 9:58 PM, Mike Adair wrote: >> >> >>> In going through these, there are a few empty model objects, >>> where it is >>> planned (or hoped) that they will eventually be filled out with >>> getter/setter methods appropriate to that document type. Yes, >>> they can >>> be replaced by the generic Model object, but I'll suggest these >>> can be >>> kept for future development. However I'm open to other ideas. >>> Comments? >>> >>> Mike >>> >>> Steven M. Ottens wrote: >>> >>>> On Jul 23, 2007, at 7:58 PM, Gertjan van Oosten wrote: >>>> >>>> >>>> >>>>> As quoted from Steven M. Ottens: >>>>> >>>>> >>>>>> Being archived: >>>>>> /lib/model/Transaction.js MAP-261 >>>>>> >>>>>> >>>>> You're kidding, right? That one is definitely being used, even by >>>>> the wfs-t >>>>> demo! >>>>> >>>>> >>>> Actually I wasn't, I'm a serious guy you know ;) >>>> Anyway, it's rather odd to have an empty model, one can use >>>> Model.js >>>> for empty models. But I'm fine with letting it stay, the whole >>>> point >>>> of this list was to make sure all my big errors were spotted >>>> before I >>>> commenced them :) >>>> >>>> >>>> >>>>>> As said before, this list isn't definitive, please comment on >>>>>> them in >>>>>> one of the (sub)subtasks of http://jira.codehaus.org/browse/ >>>>>> MAP-259 >>>>>> >>>>>> >>>>> Done (MAP-280). >>>>> >>>>> >>>> Thanks >>>> >>>> Steven >>>> >>>> >>>> >>>> ------------------------------------------------------------------- >>>> -- ---- >>>> This SF.net email is sponsored by: Splunk Inc. >>>> Still grepping through log files to find problems? Stop. >>>> Now Search log events and configuration files using AJAX and a >>>> browser. >>>> Download your FREE copy of Splunk now >> http://get.splunk.com/ >>>> _______________________________________________ >>>> mapbuilder-devel mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel >>>> >>>> >>>> >>>> >>> -------------------------------------------------------------------- >>> -- --- >>> This SF.net email is sponsored by: Splunk Inc. >>> Still grepping through log files to find problems? Stop. >>> Now Search log events and configuration files using AJAX and a >>> browser. >>> Download your FREE copy of Splunk now >> http://get.splunk.com/ >>> _______________________________________________ >>> mapbuilder-devel mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel >>> >> >> >> >> --------------------------------------------------------------------- >> ---- >> This SF.net email is sponsored by: Splunk Inc. >> Still grepping through log files to find problems? Stop. >> Now Search log events and configuration files using AJAX and a >> browser. >> Download your FREE copy of Splunk now >> http://get.splunk.com/ >> _______________________________________________ >> mapbuilder-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel >> >> > > > -- > Cameron Shorter > Systems Architect, http://lisasoft.com.au > Tel: +61 (0)2 8570 5050 > Mob: +61 (0)419 142 254 > ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ mapbuilder-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel
