Re: [MeeGo-dev] [PATCH 1/3] Fixes: NB#Account::verify and Account::verifyWithTokens() returns TRUE all the time irrespective of whether Account::sign() called or not.

[Alberto Mardegan]

On 06/14/2011 02:50 PM, Aurel Popirtac wrote:
@@ -1427,16 +1429,25 @@ END_TEST
  START_TEST(test_sign_verify_key)
  {
-    const gchar *key = "test_key/";
      const gchar *key1 = "test_key/key1";
      const gchar *key2 = "test_key/key2";
-    const gchar *list_of_tokens[] = {"t", "tok", "token", NULL};
-    const gchar *token = "token";
+    const gchar *list_of_tokens[] = {
+        "libaccounts-glib0::dummy",
+        "libaccounts-glib0::toodummy",
+        "libaccounts-glib0::accounts-glib-access", NULL };
+    const gchar *token = "libaccounts-glib0::accounts-glib-access";
+    const gchar *reply_token;
      const gchar *data = "some value 1";
      const gchar *data2 = "some value 2";
      gboolean ok;
      GValue value = { 0 };

+#ifndef HAVE_AEGISCRYPTO
+    g_debug ("test_sign_verify_key: aegis-crypto not detected, skipping.");
+    end_test ();
+    return;
+#endif

Don't you get a compiler warning when compiling without aegis-crypto?
Anyway, better wrap the whole function between HAVE_AEGISCRYPTO, and not execute 
the test when aegis-crypto is not found.

Ciao,
  Alberto

--
http://blog.mardy.it <-- geek in un lingua international!
_______________________________________________
MeeGo-dev mailing list
MeeGo-dev@meego.com
http://lists.meego.com/listinfo/meego-dev
http://wiki.meego.com/Mailing_list_guidelines