Hi Samuel.Ortiz, > 2. Add checking in ar6k_cfg80211_set_default_key(). WPA/WPA2 > can't set key with (GROUP_USAGE | TX_USAGE) > > That seems weird. So you would only be able to set default keys for WEP ?
The default key setting in only for WEP. (Tx for unicast and Group for multicast and broadcast) We don't need to set default key for WPA/WPA2. -----Original Message----- From: Chang, Samuel Sent: Friday, June 17, 2011 9:19 AM To: 'Samuel Ortiz' Cc: meego-kernel@lists.meego.com; Wu, Ricky; Huang, Maggie; Yang, Jack Subject: RE: [Meego-kernel] [PATCH] ar6003 : Can't set key with (GROUP_USAGE | TX_USAGE) for WPA/WPA2 Hi Samuel.Ortiz, Please see my comment. > 1. Remove checking in ar6k_cfg80211_connect(), it already > checks for None AUth. (NONE_AUTH == arPriv->arAuthMode) > > So this part is more of a cleanup than anything else, right ? Yes, I just want to remove unnecessary checking in this part. > 2. Add checking in ar6k_cfg80211_set_default_key(). WPA/WPA2 > can't set key with (GROUP_USAGE | TX_USAGE) > > That seems weird. So you would only be able to set default keys for WEP ? The default key is only needed by PAIRWISE key case. We know WPA/WPA2 isn't PAIRWISE key case. So, we don't (and can't) set default key for WPA/WPA2. And the WEP is PAIRWISE key case, that's why we only need to set default for it. > Without this patch, wifi firmware state machine may go wrong. > Can you elaborate on that ? What would be the consequences on the host > operations ? In ar6003 firmware, it won't do much checking. The checking task is handled in ar6003 driver. If wrong key is set, firmware will assume the key is a STATIC shared key that will install key for connected link. In this case, there will be state mismatch between connection manager and key manager modules. -----Original Message----- From: Samuel Ortiz [mailto:sa...@linux.intel.com] Sent: Thursday, June 16, 2011 10:19 PM To: Chang, Samuel Cc: meego-kernel@lists.meego.com; Wu, Ricky; Huang, Maggie; Yang, Jack Subject: Re: [Meego-kernel] [PATCH] ar6003 : Can't set key with (GROUP_USAGE | TX_USAGE) for WPA/WPA2 Hi Samuel, My comments below: On Wed, Jun 15, 2011 at 06:37:08PM +0000, Chang, Samuel wrote: > Subject: Can't set key with (GROUP_USAGE | TX_USAGE) for WPA/WPA2 > 1. Remove checking in ar6k_cfg80211_connect(), it already > checks for None AUth. (NONE_AUTH == arPriv->arAuthMode) > So this part is more of a cleanup than anything else, right ? > 2. Add checking in ar6k_cfg80211_set_default_key(). WPA/WPA2 > can't set key with (GROUP_USAGE | TX_USAGE) > That seems weird. So you would only be able to set default keys for WEP ? > Without this patch, wifi firmware state machine may go wrong. Can you elaborate on that ? What would be the consequences on the host operations ? Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ MeeGo-kernel mailing list MeeGo-kernel@lists.meego.com http://lists.meego.com/listinfo/meego-kernel
