Great, thanks for your help, I will do that. Regards, Adam
On Fri, Aug 14, 2020 at 1:30 AM Kai <kai.willad...@gmail.com> wrote: > On Fri, 14 Aug 2020 at 06:11, Adam Antium via meld-list < > meld-list@gnome.org> wrote: > >> I have a simple fix for issue #354, I posted a comment on the issue page. >> >> Are there some basic guidelines for testing code changes? How much >> checking should I be doing of, for example, path formats and stuff like >> that? >> > > For cases like this issue where there's not really much risk of unexpected > interactions with other functionality, I wouldn't worry too much about it. > Specifically in your case here, I'd probably just... check that > os.startfile does the right thing for folders, text files and "other" files > (which are the three clear cases that that code needs to handle) and that's > enough. > > Also I am a bit unsure about the cleanest way to do a code submission >> after a fix, should I check out a whole new clean source to make the >> changes in to avoid polluting it with random stuff? >> > > While the instructions are based around GNOME tools, there's a guide at > https://wiki.gnome.org/Newcomers/SubmitContribution that covers the basic > process. In short, make a fork on GNOME gitlab (where you already have an > account), clone that locally, make your changes, push a branch with your > change and create a merge request. > > When you create the MR you can see what changes you're proposing, so > that's a good time to double-check that there's nothing extraneous there. > If you have issues or questions, I'm happy to try to help out. Also don't > worry if the MR isn't perfect! It's all easy enough to change after the > fact. > > cheers, > Kai >
_______________________________________________ meld-list mailing list meld-list@gnome.org https://mail.gnome.org/mailman/listinfo/meld-list
