On 08/17/2011 08:37 PM, Chia-I Wu wrote: > On Thu, Aug 18, 2011 at 4:14 AM, Chad Versace <c...@chad-versace.us> wrote: > > > On 08/16/2011 11:28 PM, Chia-I Wu wrote: >>>> Hi list, >>>> >>>> This patch series adds Android Gingerbread support to Mesa. To begin >>>> with, it only supports software rendering with softpipe. I've tested >>>> it with VirtualBox. There are pending series that enable all other >>>> gallium pipe drivers and the classic i915/i965. I would like to see >>>> how this series goes before sending them out. >>>> >>>> If you are familiar with Android-x86, you can replace external/mesa by >>>> the master branch plus this series, and build the image like this >>>> >>>> $ make -j2 iso_img BOARD_GPU_DRIVERS=swrast >>>> >>>> The first five patches fix build issues with Android's toolchain and >>>> libc. They are generally pretty small. >>>> >>>> Patch 6-8 adds Android Gingerbread support to core EGL and st/egl. >>>> They are quite isolated and should be interesting to EGL developers. >>>> >>>> Patch 9-18 adds Android.mk's to the source tree. The Android build >>>> system will include them and build mesa when BOARD_GPU_DRIVERS is >>>> defined. >>>> >>>> This series is RFC because Android.mk's duplicate the source lists in >>>> Makefile's. It means it will suffer from the same pain as SCons does: >>>> it needs to be updated if a new file is added. Chad has concerns >>>> about this. Since he also needs to work on that for his series, I >>>> will join him and update Android.mk's accordingly. >>>> >>>> Other than that, please review. > > Chia-I, > > I'm glad to see your Android patches on the list. Now the Mesa > and Android-x86 communities can begin to fold Android support into > master and make progress towards a stable Mesa on Android. > > I've commented, acked, or rb'd all the patches that are within my > domain. I've avoided commenting on patches specific to Gallium. >> Thanks. > >> Do you suggest we factor out the source lists before or after this >> patch series? Outside Gallium, there are only src/egl/main and >> src/glsl that need factoring out. When later support for non-Gallium >> drivers[1] is supported, there will also be >> src/mesa/drivers/dri/{i915,i965}.
I think it is best if you go ahead and commit the patches that you have posted to the list (but after we resolve the issue of how libGLES_mesa is built, of course). They will have already been reviewed, and the makefile cleanups required for src/glsl and src/mesa are minimal. It will be simple to do the refactoring after your patches land. Now that I see how you intend to proceed with sharing sources.mak, tomorrow I will create sources.mak for the i915 and i965 directories. That way, src/mesa/drivers/dri/Android.mk will not require extensive (if any) refactoring. -- Chad Versace c...@chad-versace.us _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev