On 25.01.2016 10:04, Ilia Mirkin wrote:
Yeah so this isn't going to fly. r600/radeonsi both expose
PIPE_CAP_COMPUTE, for clover, but won't support these compute shaders
quite yet. Not sure what the solution is here... maybe just add
another cap? PIPE_CAP_GLSL_COMPUTE or something? Or require a backend
to also set PIPE_CAP_GLSL_VERSION to 430 for ARB_compute_shader to
become exposed? Don't know.

GLSL 430 also requires arrays_of_arrays. I don't actually know how much we need to do to support that, but maybe it'd be better not to depend on that.

A new cap is an option. A slightly weird but I think reasonable option would be to require a PIPE_CAP_GLSL_VERSION of 420, since ARB_compute_shader officially requires OpenGL 4.2 anyway, and then let us deal with the fallout when we up that version number.

Cheers,
Nicolai


   -ilia

On Sun, Jan 24, 2016 at 4:09 PM, Samuel Pitoiset
<samuel.pitoi...@gmail.com> wrote:
Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com>
---
  src/mesa/state_tracker/st_extensions.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/src/mesa/state_tracker/st_extensions.c 
b/src/mesa/state_tracker/st_extensions.c
index 2374dcc..ec30d99 100644
--- a/src/mesa/state_tracker/st_extensions.c
+++ b/src/mesa/state_tracker/st_extensions.c
@@ -489,6 +489,7 @@ void st_init_extensions(struct pipe_screen *screen,
        { o(ARB_clear_texture),                PIPE_CAP_CLEAR_TEXTURE           
         },
        { o(ARB_clip_control),                 PIPE_CAP_CLIP_HALFZ              
         },
        { o(ARB_color_buffer_float),           PIPE_CAP_VERTEX_COLOR_UNCLAMPED  
         },
+      { o(ARB_compute_shader),               PIPE_CAP_COMPUTE                  
        },
        { o(ARB_conditional_render_inverted),  
PIPE_CAP_CONDITIONAL_RENDER_INVERTED      },
        { o(ARB_copy_image),                   
PIPE_CAP_COPY_BETWEEN_COMPRESSED_AND_PLAIN_FORMATS },
        { o(ARB_depth_clamp),                  PIPE_CAP_DEPTH_CLIP_DISABLE      
         },
--
2.6.4

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to