Hi Rob, Speaking of maintainers... I have a patch somewhere that adds you as maintainer for $linux/drivers/drm/gpu/msm/. Guess I should send it already ;-)
On 19 April 2016 at 22:11, Rob Clark <robdcl...@gmail.com> wrote: > From: Rob Clark <robcl...@freedesktop.org> > > Copied from linux kernel, with minimal changes to script (just to > recognize mesa src tree rather than linux kernel src tree), and slimmed > down MAINTAINER file syntax to recognize that we don't really have > subsystem "maintainers" in the same sense as the linux kernel (ie. no > different mailing lists and git trees per subsystem). > Crazy idea: Worth mentioning the commit this based upon and tracking all the changes in git ? This way one can leech from the kernel and contribute back as applicable ;-) > The main point is to automate slapping on the correct CC's for patches > via git's --cc-cmd feature, more than anything else. > > I didn't attempt to fully populate the MAINTAINERS file, by a long shot. > The point was to just be able to test it, and get feedback if people > like the idea. > Fwiw the idea sounds great imho. There is a small warning though - the script is under the GPLv2 licence. Would that interfere with BSD/Solaris/companies that ship mesa based binaries ? If it's a matter of not shipping the script [in the tarball] that's great. Although it's worth checking. > If you like the idea, let me know which file paths/subsystems you want > me to add you to as designated reviewer ;-) > --- > MAINTAINERS | 49 + > scripts/get_maintainer.pl | 2300 > +++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 2349 insertions(+) > create mode 100644 MAINTAINERS > create mode 100755 scripts/get_maintainer.pl > > diff --git a/MAINTAINERS b/MAINTAINERS > new file mode 100644 > index 0000000..52f64cb > --- /dev/null > +++ b/MAINTAINERS > @@ -0,0 +1,49 @@ > +Overview: > + > + This file is similar in syntax (or more precisly a subset) of what is > used s/precisly/precisely/ > + for the linux kernel. Some fields do not apply (for example, in all > cases, > + send patches to mesa-dev@lists.freedesktop.org, and in all cases the > + patchwork instance is > https://patchwork.freedesktop.org/project/mesa/), > + but is meant to give an idea of who to CC on various patches, and to > allow > + for the use of scripts/get_maintainer.pl as git --cc-cmd. > + > +Descriptions of section entries: > + > + R: Designated reviewer: FullName <address@domain> > + These reviewers should be CCed on patches. > + F: Files and directories with wildcard patterns. > + A trailing slash includes all files and subdirectory files. > + F: drivers/net/ all files in and below drivers/net > + F: drivers/net/* all files in drivers/net, but not below > + F: */net/* all files in "any top level directory"/net > + One pattern per line. Multiple F: lines acceptable. > + N: Files and directories with regex patterns. > + N: [^a-z]tegra all files whose path contains the word tegra [Really nit-picky] The examples above could be updated > + One pattern per line. Multiple N: lines acceptable. > + scripts/get_maintainer.pl has different behavior for files that > + match F: pattern and matches of N: patterns. By default, > + get_maintainer will not look at git log history when an F: pattern > + match occurs. When an N: match occurs, git log history is used > + to also notify the people that have git commit signatures. > + > +Note: For the hard of thinking, this list is meant to remain in alphabetical > +order. If you could add yourselves to it in alphabetical order that would be > +so much easier [Ed] > + > +Maintainers List (try to look for most precise areas first) > + > + ----------------------------------- > + > +FREEDRENO > +R: Rob Clark <robcl...@freedesktop.org> > +F: src/gallium/drivers/freedreno/ > + > +NIR > +R: Jason Ekstrand <ja...@jlekstrand.net> > +R: Connor Abbott <cwabbo...@gmail.com> > +F: src/compiler/nir/ > + > +VC4 > +R: Eric Anholt <e...@anholt.net> > +F: src/gallium/drivers/vc4/ > + The order is a bit funny, so feel free to tweak the way you prefer. Documentation R: Emil Velikov <emil.l.veli...@gmail.com> F: docs/ Doxygen R: Rhys, Sarah ? F: doxygen/ Compatibility headers R: Emil Velikov <emil.l.veli...@gmail.com> F: include/c99* DRI loader R: Emil Velikov <emil.l.veli...@gmail.com> F: src/loader/ Gallium loader R: Emil Velikov <emil.l.veli...@gmail.com> F: src/gallium/auxiliary/pipe-loader/ F: src/gallium/auxiliary/target-helpers/ Gallium targets R: Emil Velikov <emil.l.veli...@gmail.com> F: src/gallium/targets/ Build systems - yay (boo) Autoconf build R: Emil Velikov <emil.l.veli...@gmail.com> F: configure.ac F: */Automake.inc F: */Makefile.*am F: */Makefile.sources And maybe other build systems ? Scons build R: Jose, Brian ? F: scons/ F: */SConscript* F: */Makefile.sources Android build R: Emil Velikov <emil.l.veli...@gmail.com> R: Rob H, Chih Wei ? L: android-x86... mailing list ? F: CleanSpec.mk F: */Android.*mk F: */Makefile.sources I could also chip-in on glx and egl if needed. > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl > new file mode 100755 > index 0000000..6178806 > --- /dev/null > +++ b/scripts/get_maintainer.pl > +my @penguin_chief = (); > +push(@penguin_chief, "Linus Torvalds:torvalds\@linux-foundation.org"); > +#Andrew wants in on most everything - 2009/01/14 > +#push(@penguin_chief, "Andrew Morton:akpm\@linux-foundation.org"); > + Haven't really checked what these do but imho they should be updated ? Thanks Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev