On Wed 06 Jul 2016, Chad Versace wrote: > On Mon 20 Jun 2016, Guillaume Charifi wrote: > > Fixes a regression induced by commit > > a0674ce5c41903ccd161e89abb149621bfbc40d2: > > When EGL_TEXTURE_FORMAT and EGL_TEXTURE_TARGET were both specified (and > > both != EGL_NO_TEXTURE), an error was instantly triggered, before the > > other one had even a chance to be checked, which is obviously not the > > intended behaviour. > > > > v2: Full commit hash, remove useless variables. > > > > Signed-off-by: Guillaume Charifi <guillaume.char...@sfr.fr> > > Reviewed-by: Frank Binns <frank.bi...@imgtec.com> > > --- > > src/egl/main/eglsurface.c | 36 +++++++++++++++--------------------- > > 1 file changed, 15 insertions(+), 21 deletions(-) > > This patch looks good to me. And I checked that it didn't regress > dEQP-EGL.functional.negative_api.create_pbuffer_surface. > > But I want to run the patch through Intel's Jenkins before giving my > reviewed-and-tested-by. The Jenkins run should finish before morning > (I'm US West Coast).
I verified that your patch regresses no tests in 'dEQP-EGL.*', at least on Intel. So, it's looking good. I'm still waiting for the full Jenkins run to complete, though. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev