On Fri, 2017-01-27 at 09:46 +0000, Lionel Landwerlin wrote:
> > But what the test does is calling OpSpecConstantOp[2], which is the
> > operation we are patching here.
> >
> > And according to the spec, "all Operands must be the <id>s of other
> > constant instructions", being constant instructions those starting with
> > OpConstant or OpSpec. In this regard, OpUndef is not a constant.
>
> I noticed this indeed. Given that test were specifically written to test
> this, I thought OpVectorShuffle had priority on this rule.
>
I think that when calling OpVectorShuffle directly, OpUndef can be
used, but when using through OpSpecConstantsOp, the operands are
restricted to constants.
> I just filed a bug against the spec to get clarification on this.
I was to send a fix to the test, to remove the OpUndef usage. But I
think I'll wait until this is clarified. Thanks!
J.A.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
