On Monday, 2017-06-12 09:39:15 +0300, Tapani Pälli wrote: > Hi Eric; > > EGL_KHR_swap_buffers_with_damage is implemented by Android's EGL wrapper > library so these tests are passing already, no implementation required in > Mesa side.
Right, I keep forgetting that android intercepts some stuff and lets the rest through to mesa. So 2/2 is unnecessary, but should we still land 1/2? At worst, it's an unnecessary call to a `return false` function, and at best it sets the correct damage before swapping. There's an alternative "worst", which would be a platform on which swap_buffers_with_damage != set_damage_region + swap_buffers, but on such a platform the fallback shouldn't be used anyway, so using it would be the bug. What do you think? _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
