Ouch. The frustrating thing is that anisotropic filtering is so underspecified (intentionally) that it's hard to write tests that will detect these kinds of problems and also work across multiple vendors. :(
Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> On 06/27/2017 10:37 AM, Rafael Antognolli wrote: > From: Eero Tamminen <eero.t.tammi...@intel.com> > > Commit f8d69beed49c64f883bb8ffb28d4960306baf575 moving sampler > handling to genxml messed up change done by commit > 6a7c5257cac23cd9767aa4bc8fdab68925b11157. > > This broke rendering in SynMark CSDof and TexFilterAniso tests. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101607 > > Thanks to Kevin, who spotted the actual typo! > --- > src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c > b/src/mesa/drivers/dri/i965/genX_state_upload.c > index d65b468..06b9cd5 100644 > --- a/src/mesa/drivers/dri/i965/genX_state_upload.c > +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c > @@ -4551,7 +4551,7 @@ genX(update_sampler_state)(struct brw_context *brw, > if (sampler->MaxAnisotropy > 1.0f) { > if (samp_st.MinModeFilter == MAPFILTER_LINEAR) > samp_st.MinModeFilter = MAPFILTER_ANISOTROPIC; > - if (samp_st.MinModeFilter == MAPFILTER_LINEAR) > + if (samp_st.MagModeFilter == MAPFILTER_LINEAR) > samp_st.MagModeFilter = MAPFILTER_ANISOTROPIC; > > if (sampler->MaxAnisotropy > 2.0f) { > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
