On Tue, Aug 8, 2017 at 6:57 PM, Samuel Pitoiset
<samuel.pitoi...@gmail.com> wrote:
> Using VRAM address as bindless handles is not a good idea because
> we have to use LLVMIntToPTr and the LLVM CSE pass can't optimize
> because it has no information about the pointer.
>
> Instead, use slots indexes like the existing descriptors. Note
> that we use fixed 16-dword slots for both samplers and images.
> This doesn't really matter because no real apps use image handles.
>
> This improves performance with DOW3 by +7%.
>
> v3: - fix si_emit_global_shader_pointers() for merged GFX9 shaders
>     - always re-upload the array of descriptors at creation time
> v2: - inline si_release_bindless_descriptors()

I meant that you inline the function manually. Anyway:

Reviewed-by: Marek Olšák <marek.ol...@amd.com>

Marek
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to